Skip to content

Fix workflows: upstream renamed facebook/react → react/react - #557

Open
mahdyaralipor wants to merge 2 commits into
reactjs:mainfrom
mahdyaralipor:fix-label-workflow-upstream-rename
Open

mahdyaralipor wants to merge 2 commits into
reactjs:mainfrom
mahdyaralipor:fix-label-workflow-upstream-rename

Conversation

@mahdyaralipor

@mahdyaralipor mahdyaralipor commented Oct 4, 2026 •

Copy link
Copy Markdown

دو ورک‌فلو (Label Core Team PRs و Discord Notify) به facebook/react ارجاع می‌دادند، ولی ریپوی اصلی به react/react منتقل شده و گیت‌هاب اسم قدیمی را برای uses: دنبال نمی‌کند. نتیجه: خطای workflow was not found روی همه PRها.\n\nاین PR هر دو ارجاع را به اسم جدید تغییر می‌دهد. فایل مقصد (shared_check_maintainer.yml@main) سالم است و تریگر workflow_call دارد.\n\nبقیه موارد facebook/react در ریپو فقط لینک https معمولی‌اند (ریدایرکت مرورگر کار می‌کند) و پارس Actions را خراب نمی‌کنند.

@vercel

vercel Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
fa-legacy-reactjs-org Ignored Ignored Preview Oct 4, 2026 12:50pm UTC

Request Review

@mahdyaralipor mahdyaralipor changed the title Fix label_core_team_prs.yml: upstream renamed facebook/react → react/react Fix workflows: upstream renamed facebook/react → react/react Oct 4, 2026
@mahdyaralipor

Copy link
Copy Markdown
Author

Hi maintainers! This PR is ready for review. It fixes the broken Label Core Team PRs and Discord Notify workflows (both fail on every PR with workflow was not found because they still reference facebook/react, which was renamed to react/react). Just a 2-line change — would appreciate a look. Thanks! 🙏

@maqsood576 maqsood576 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check_maintainer job defines the uses key twice with different reusable workflow references. YAML does not support duplicate keys reliably, and a GitHub Actions job can reference only one reusable workflow. Please verify the intended repository and keep a single uses entry.

@maqsood576

Copy link
Copy Markdown

The check_maintainer job defines the uses key twice with different reusable workflow references. YAML does not support duplicate keys reliably, and a GitHub Actions job can reference only one reusable workflow. Please verify the intended repository and keep a single uses entry.

@mahdyaralipor

Copy link
Copy Markdown
Author

Thanks for the review. I re-checked the head commit (97ea57c) and there is only one uses: key per job — the diff replaces the existing value on that line, it does not add a second one:

  • .github/workflows/label_core_team_prs.yml line 14 → uses: react/react/.github/workflows/shared_check_maintainer.yml@main
  • .github/workflows/discord_notify.yml line 11 → same reference

The permissions: and with: blocks right below it belong to that same single job, so the YAML has no duplicate key (GitHub would reject the whole workflow file otherwise, and both files parse fine today).

I also verified the target workflow still exposes the workflow_call interface this repo consumes: react/react/.github/workflows/shared_check_maintainer.yml@main takes the actor input and returns the is_core_team output used by the if: conditions here. facebook/react and react/react resolve to the same file, but uses: does not follow the repo rename, which is why these two workflows fail on every PR with workflow was not found.

Friendly bump for the maintainers: this is a 2-line fix and both Label Core Team PRs and Discord Notify are still broken on every incoming PR. Happy to adjust anything you'd prefer. 🙏

This branch was successfully deployed

1 active deployment
Preview – fa-react-dev — 97ea57c9 Deployed Oct 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants